Move phpcs configuration from the-build into a phpcs.xml file #185
Conversation
|
Ooh, maybe we can do this for phpmd too. |
|
@becw I tried testing this on a live project; however, I didn't have a good one where I could actually push something up, so I was just testing by running the Maybe it would be best to just find a project where I can make this change in a PR and push it up to truly test the build tooling 🤔 |
|
I think Eric was getting more coding errors/suggestions because the old coding standard was just "Drupal", and this phpcs file has both "Drupal" and "DrupalPractice". I think for new projects, having both in place is better. |
becw
force-pushed
the
phpcs-config-file
branch
from
8a56e2a to
8499d85
Compare
Alternative to #183.
This pulls out all of the phpcs config from the-build and puts it in a default
phpcs.xmlfile. This should allow running the project's phpcs config by just runningphpcs(orvendor/bin/phpcs) without any special arguments. It also makes it more visible to developers new to a project that phpcs is available.This config file should probably be tested in an actual project.
If a project updates from an older version of the-build to a version that includes these changes, they would need to:
build.xmlto use the new command